[PATCH] D78799: [llvm-objcopy][MachO] Fix segment's vmsize
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 24 09:44:08 PDT 2020
MaskRay added a comment.
> Fix the calculation of vmsize.
Hope this can be expanded a bit to describe why the current code is wrong.
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/segments-vmsize.test:25
+FileHeader:
+ magic: 0xFEEDFACF
+ cputype: 0x01000007
----------------
The long test (200+) makes it really unwieldy when we later want to reorganize tests. See ELF/ for some short examples. Can we simplify the YAML input a bit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78799/new/
https://reviews.llvm.org/D78799
More information about the llvm-commits
mailing list