[PATCH] D72223: [MLIR] Introduce affine.execute_region op

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D72223#2001800 <https://reviews.llvm.org/D72223#2001800>, @ftynse wrote:

> I am very sorry, for some reason this diff was not appearing on my phabricator todo list until recently.... Please do not hesitate to ping me by email if I take more than a couple of workdays to iterate.
>
> In general, this change makes sense to me and looks like a proper extension of the affine modeling. My only design concern is that one can circumvent the explicit-capture mechanism for memrefs. A direct solution would be to disallow any values of memref type to be defined in the region, but I have not considered the implications of this on the expressiveness.
>
> There are several places where some action is performed twice (e.g., parsing attribute dict), requesting change for these.


Thanks for the detailed review! Yes, we need to still converge on the memref explicit capture. But I'll address these other straightforward changes first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223