[PATCH] D78805: [llvm-readobj][test] - Stop using binaries in gnu-phdrs.test and refine it.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 24 05:22:24 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, atanasyan, kristof.beyls, arichardson, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.

gnu-phdrs.test uses 2 precompiled objects and has issues:

- It does not test all possible program headers.
- It does not test target-specific headers (arm, mips).
- It does not use --strict-whitespace --match-full-line to check the format of the output.
- It is possible to check things better/nicer.

This patch makes gnu-phdrs.test to stop using binaries and addresses issues above.

I am going to use it as a base for a follow-up patch that should also test
all section to segment mapping conditions that we currently have
(see the discussion in D78709 <https://reviews.llvm.org/D78709>)


https://reviews.llvm.org/D78805

Files:
  llvm/test/tools/llvm-readobj/ELF/Inputs/phdrs-elf.exe-i386
  llvm/test/tools/llvm-readobj/ELF/Inputs/phdrs-elf.exe-x86_64
  llvm/test/tools/llvm-readobj/ELF/gnu-phdrs.test
  llvm/test/tools/llvm-readobj/ELF/gnu-section-mapping-no-shdrs.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78805.259863.patch
Type: text/x-patch
Size: 21774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200424/02bf8048/attachment.bin>


More information about the llvm-commits mailing list