[PATCH] D78768: [VE] Update floating-point arithmetic instructions

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

One comment inline. Otw, LGTM.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:1168
 // Cast to f32
-def : Pat<(f32 (sint_to_fp i64:$sy)), (CVSr (FLTXr i64:$sy))>;
+def : Pat<(f32 (sint_to_fp i64:$sy)), (CVTSDr (CVTDLr i64:$sy))>;
 
----------------
Doesn't the CVTLDr require an explicit rounding mode as in l1164f above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78768/new/

https://reviews.llvm.org/D78768