[PATCH] D78727: [mlir][StandardToSPIRV] Fix test cases where DCE removes all the code.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 22:46:45 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/test/Conversion/StandardToSPIRV/subview-to-spirv.mlir:1
-// RUN: mlir-opt -legalize-std-for-spirv -convert-std-to-spirv %s -o - | FileCheck %s
+// RUN: mlir-opt -legalize-std-for-spirv %s -o - | FileCheck %s
 
----------------
Why is the name `legalize-...` instead of `convert-...` here? Is there some subtle difference or this was not intentional to diverge from the usual convention here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78727/new/

https://reviews.llvm.org/D78727





More information about the llvm-commits mailing list