[PATCH] D78691: [mlir][EDSC] Retire ValueHandle

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 21:42:33 PDT 2020


bondhugula added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/EDSC/Builders.cpp:87-89
       SmallVector<Value, 4>(lbHandles.begin(), lbHandles.end()),
       SmallVector<Value, 4>(ubHandles.begin(), ubHandles.end()),
       SmallVector<Value, 4>(steps.begin(), steps.end()));
----------------
Do we need these SmallVector's? You can change the args for this to ValueRange's actually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78691/new/

https://reviews.llvm.org/D78691





More information about the llvm-commits mailing list