[PATCH] D78600: DenseStringElementsAttr added to default attribute types

[Rob Suderman via Phabricator via llvm-commits]

rsuderman marked 7 inline comments as done.
rsuderman added inline comments.


================
Comment at: mlir/include/mlir/IR/Attributes.h:890
 
+  llvm::iterator_range<ElementIterator<StringRef>> getValues() const {
+    auto stringRefs = getStringRefs();
----------------
rriddle wrote:
> nit: drop the llvm:: from the iterator_range
Dropping the llvm:: results in build errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78600/new/

https://reviews.llvm.org/D78600