[PATCH] D78672: [Debuginfo] Remove redundand variable from getAttributeValue()

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

> Yes, much cleaner! I look forward to seeing any perf optimizations in the future if they prove to be faster. It really depends on how many workflows directly access attributes. It is probably quite common for symbolication where it will look for low and high pc and name.

I also have in mind some optimization which would limit number of passes through attributes values. It is often necessary to get not only single attribute, but pair or triple. Currently it leads to several calls to find() and then several passes through attributes values. It is generally possible to get all required attributes through the one pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78672/new/

https://reviews.llvm.org/D78672