[PATCH] D78731: [MLIR] Replace splitBlock() with createBlock in GenericAtomicRMWOp lowering.

Alexander Belyaev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 12:28:35 PDT 2020


pifon2a added a comment.

In D78731#1999664 <https://reviews.llvm.org/D78731#1999664>, @ftynse wrote:

> > splitBlock is not undoable and should not be used in ConversionPattern.
>
> splitBlock _is_ undoable, it's adding an argument to the block that is not


Thanks and PTAL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78731/new/

https://reviews.llvm.org/D78731





More information about the llvm-commits mailing list