[PATCH] D78645: [mlir] Add a ViewLikeOpInterface

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 11:21:36 PDT 2020


rriddle accepted this revision.
rriddle added a comment.
Herald added a subscriber: Kayjukh.

I think this is fine for now.



================
Comment at: mlir/include/mlir/Interfaces/ViewLikeInterface.td:21
+    A view-like operation "views" a buffer in a potentially different way. It
+    takes in a memref (and potentially some other operands) and returns another
+    memref.
----------------
You could avoid the word "memref" here altogether and just use buffer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78645/new/

https://reviews.llvm.org/D78645





More information about the llvm-commits mailing list