[PATCH] D77807: [LLD][ELF] Implement --discard-* for cases when -r or --emit-relocs are used.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 23 09:43:35 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/emit-relocs-discard-locals.s:27
+
+## --discard-locals removes unused local symbols which start with ".L"
+# DISCARD-LOCALS:    0: {{0+}} 0 NOTYPE  LOCAL  DEFAULT UND
----------------
I think you can still combine the two chunks of CHECK lines. 

`DICARD-LOCALS-NEXT:` for the common part.
`DISCARD-LOCALS-NOGC` for the additional lines by --no-gc-sections.

It makes the diff stand out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77807/new/

https://reviews.llvm.org/D77807





More information about the llvm-commits mailing list