[PATCH] D78635: [NFC][TTI] Add TargetCostKind argument to getUserCost

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:157
+    TCK_CodeSize,        ///< Instruction code size.
+    TCK_Hybrid           ///< Intersection of size and performance.
   };
----------------
samparker wrote:
> mtrofin wrote:
> > Would 'workingset' accurately describe what the 'hybrid' is used for, so a weighed sum of code and latency? I'm having trouble wrapping my mind around the old  'intersection' notion (what would intersecting 2 costs mean?), and 'hybrid', at a first glance, leads me to believe it's about combining all other 3. 
> I also don't know what it means, I just quoted it from below :) and I agree that Hybrid is not descriptive. I would probably prefer to be as explicit as possible with something like SizeAndLatencyWeight.
I think TCK_SizeAndLatency, with a descriptive comment, would probably communicate it clearly enough (and keep it reasonably concise)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78635/new/

https://reviews.llvm.org/D78635