[PATCH] D46472: [HIP] Support offloading by linker script

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329
+  // Get the HIP offload tool chain.
+  auto *HIPTC = static_cast<const toolchains::CudaToolChain *>(
+      C.getSingleOffloadToolChain<Action::OFK_HIP>());
----------------
JonChesterfield wrote:
> Should this be `toolchains::HipToolChain`?
will fix. thanks


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46472/new/

https://reviews.llvm.org/D46472