[PATCH] D78692: [mlir][EDSC] Retire OperationHandle

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.
This revision is now accepted and ready to land.

Nice clean-up!



================
Comment at: mlir/include/mlir/EDSC/Builders.h:179
+  friend LoopBuilder makeAffineLoopBuilder(Value *iv, ArrayRef<Value> lbs,
+                                           ArrayRef<Value> ubs, int64_t step);
   friend LoopBuilder makeParallelLoopBuilder(MutableArrayRef<Value> ivs,
----------------
Nit (and likely for a separate clean-up): ArrayRef<Value> -> ValueRange


================
Comment at: mlir/lib/Dialect/LoopOps/EDSC/Builders.cpp:110
+mlir::edsc::makeLoopBuilder(Value *iv, Value lb, Value ub, Value step,
+                            MutableArrayRef<Value> iterArgsHandles,
+                            ValueRange iterArgsInitValues) {
----------------
Nit: these aren't handles anymore AFAICS


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78692/new/

https://reviews.llvm.org/D78692