[PATCH] D78647: [MLIR] Lower GenericAtomicRMWOp to llvm.cmpxchg.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:2796
+    auto *loopBlock = rewriter.splitBlock(initBlock, initPosition);
+    auto loopArgument = loopBlock->addArgument(valueType);
+    auto loopPosition = rewriter.getInsertionPoint();
----------------
This is not allowed in conversion patterns (it is not undoable). I've recently introduced a functionality to create block in a rewriter-compatible way, `rewriter.createBlock(initBlock->getParent(), std::next(Region::iterator(initBlock)), valueType);` should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78647/new/

https://reviews.llvm.org/D78647