[PATCH] D78608: [llvm] [CodeGen] Fixed vector halving bug for masked load

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1596
+    // remove the unused element in the chain.
+    Hi = Lo;
+  } else {
----------------
Could we return PassThruHi directly?


================
Comment at: llvm/test/CodeGen/X86/pr45563-2.ll:1
+; RUN: llc < %s -O3 -mattr=avx | FileCheck %s
+
----------------
Please use update_llc_test_checks on tests this size


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78608/new/

https://reviews.llvm.org/D78608