[PATCH] D78666: [llvm][NFC][CallSite] Remove CallSite from TypeMetadataUtils & related

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 22:46:47 PDT 2020


mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:356
 struct VirtualCallSite {
-  Value *VTable;
-  CallSite CS;
+  Value *VTable = nullptr;
+  CallBase &CB;
----------------
craig.topper wrote:
> Why the "= nullptr"?
Drive-by change. Lower chance of later maintainability issues, and it's easy and harmless to set it here (same for NumUnsafeUses)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78666/new/

https://reviews.llvm.org/D78666





More information about the llvm-commits mailing list