[PATCH] D78691: [mlir][EDSC] Retire ValueHandle

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache created this revision.
nicolasvasilache added a reviewer: ftynse.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: herhut.
Herald added a reviewer: aartbik.
Herald added a project: LLVM.

The EDSC discussion thread <https://llvm.discourse.group/t/evolving-builder-apis-based-on-lessons-learned-from-edsc/879> points out that ValueHandle has become an unnecessary level of abstraction since MLIR switch from `Value *` to `Value` everywhere.

This revision removes this level of indirection.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78691

Files:
  mlir/docs/Dialects/Linalg.md
  mlir/docs/EDSC.md
  mlir/include/mlir/Dialect/Affine/EDSC/Builders.h
  mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
  mlir/include/mlir/Dialect/Linalg/EDSC/FoldedIntrinsics.h
  mlir/include/mlir/Dialect/LoopOps/EDSC/Builders.h
  mlir/include/mlir/Dialect/StandardOps/EDSC/Builders.h
  mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
  mlir/include/mlir/Dialect/Vector/EDSC/Intrinsics.h
  mlir/include/mlir/EDSC/Builders.h
  mlir/include/mlir/EDSC/Intrinsics.h
  mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
  mlir/lib/Dialect/Affine/EDSC/Builders.cpp
  mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
  mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
  mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
  mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
  mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp
  mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
  mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
  mlir/lib/Dialect/LoopOps/EDSC/Builders.cpp
  mlir/lib/Dialect/StandardOps/EDSC/Builders.cpp
  mlir/lib/Dialect/StandardOps/EDSC/Intrinsics.cpp
  mlir/lib/EDSC/Builders.cpp
  mlir/test/EDSC/builder-api-test.cpp
  mlir/test/mlir-linalg-ods-gen/test-linalg-ods-gen.tc
  mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78691.259470.patch
Type: text/x-patch
Size: 162918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200423/ba6a899a/attachment-0001.bin>