[PATCH] D78657: [PowerPC] Fix the liveins for ppc-expand-isel pass

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 20:06:36 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCExpandISEL.cpp:390
-    // in MBB should be treated as liveins of NewSuccessor.
-    // Note: Cannot use stepBackward instead since we are using the Reg
-    // liveness state at the end of MBB (liveOut of MBB) as the liveIn for
----------------
I notice `computeAndAddLiveIns` will call `stepBackward`, this comment says it will lead to cyclic dependence. Is it still the case for current code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78657/new/

https://reviews.llvm.org/D78657





More information about the llvm-commits mailing list