[PATCH] D78602: [llvm-objcopy][MachO] Copy LC_LOAD_WEAK_DYLIB load commands

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/lc-weak-dylib.test.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy %t %t.copy
----------------
MaskRay wrote:
> Should the file be
> 
> lc-weak-dylib.test
> 
> or
> 
> lc-load-weak-dylib.test
> 
> ?
personally i think if we prefer dashes in such cases it should be lc-load-weak-dylib.test,
i don't mind renaming this test again, however, the above comment was suggesting the following: 
"perhaps lc-weak-dylib.test for this test".
I think  lc-load-weak-dylib.test is a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78602/new/

https://reviews.llvm.org/D78602