[PATCH] D78340: [Flang] fix dependency issues after D78215

Wed Apr 22 16:20:57 PDT 2020

clementval added a comment.

In D78340#1997821 <https://reviews.llvm.org/D78340#1997821>, @ro wrote:

> This change broke `-DBUILD_SHARED_LIBS=ON` builds (seen on x86_64-pc-linux-gnu):
>
>   CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
>     "FortranEvaluate" of type SHARED_LIBRARY
>       depends on "FortranSemantics" (weak)
>     "FortranSemantics" of type SHARED_LIBRARY
>       depends on "FortranEvaluate" (weak)
>   At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.
>

The cycle dependency was removed with D78215 <https://reviews.llvm.org/D78215> which was breaking static build. The dependency is needed until it is really removed in the libraries themselves.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78340/new/

https://reviews.llvm.org/D78340