[PATCH] D74651: Add IR constructs for inalloca replacement preallocated call setup

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Your proposed solution to finding the correct type of an allocation with a corresponding call seems fine.

Not sure about rewrite llvm.call.preallocated.arg to an alloca.  Not sure you'd actually want to explicitly rewrite it; probably simpler to come up with some fake stack layout and go through the normal lowering.

On a related note, I just realized there isn't any discussion of alignment in the documentation.  Have you thought about how the alignment of preallocated arguments is specified?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651