[PATCH] D78664: [AMDGPU] Add the SGPR used for FP copy to block livein lists.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 14:41:52 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:617
       .setMIFlag(MachineInstr::FrameSetup);
+    // make the register live throughout the function.
+    for (MachineBasicBlock &MBB : MF)
----------------
Capitalize


================
Comment at: llvm/test/CodeGen/AMDGPU/fix-frame-ptr-reg-copy-livein.ll:4
+%struct.Data = type { [20 x i32] }
+
+define i32 @fp_save_restore_in_temp_sgpr(%struct.Data addrspace(5)* nocapture readonly byval(%struct.Data) align 4 %arg) #0 {
----------------
Can you add a comment explaining what this tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78664/new/

https://reviews.llvm.org/D78664





More information about the llvm-commits mailing list