[PATCH] D78306: [flang] Use LLVM's flags

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: flang/CMakeLists.txt:62
   endif()
+  option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)
+  option(LLVM_ENABLE_WERROR "Fail and stop if a warning is triggered." ON)
----------------
ChinouneMehdi wrote:
> `LLVM_ENABLE_WARNINGS` is enabled by default.
Projects having Werror enabled by default one of the reasons why it is hard to implement new warnings. Please don't.

For instance, I fixed false-negative warnings in Clang. The patch was reverted because it broke the Chrome build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78306/new/

https://reviews.llvm.org/D78306