[PATCH] D78665: [TLI] Optimize no-builtins attribute check (NFC)

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 13:37:29 PDT 2020


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Nice find/fix. Lgtm



================
Comment at: include/llvm/Analysis/TargetLibraryInfo.h:236
+      if (AttrStr == "no-builtins") {
+        disableAllFunctions();
+      } else if (AttrStr.consume_front("no-builtin-")) {
----------------
You could break out of the loop in this case. Although that won't work any more if this loop is extended to look for veclib unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78665/new/

https://reviews.llvm.org/D78665





More information about the llvm-commits mailing list