[PATCH] D78617: [UpdateTestChecks] Make generation of UTC_ARGS: comment more robust

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 13:03:27 PDT 2020


arichardson marked an inline comment as done.
arichardson added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected:10
+
+; UTC_ARGS: --disable
+
----------------
jdoerfert wrote:
> I'm afraid with this line we do not test if the disable in the first line has an effect. We might need another test, sorry.
We do, without the first disable there would be check lines for the first function. (See the other .expected file for this test)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78617/new/

https://reviews.llvm.org/D78617





More information about the llvm-commits mailing list