[PATCH] D78411: [AArch64LoadStoreOptimizer] Skip debug insts during pattern matching
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 22 11:26:16 PDT 2020
vsk added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/ldst-opt-mte.mir:1
-# RUN: llc -mtriple=aarch64-none-linux-gnu -run-pass aarch64-ldst-opt -verify-machineinstrs -o - %s | FileCheck %s
---
----------------
fhahn wrote:
> I think it would be slightly better to have the version with DBG_VALUE as separate test, as it unnecessarily clutters the test with respect to the core functionality.
I see; let's add a -mir-debugify run line to the original test so that extensions to the pass get tested with debug info, and then copy the test to have coverage for the case where there are multiple DBG_VALUEs between instruction pairs?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78411/new/
https://reviews.llvm.org/D78411
More information about the llvm-commits
mailing list