[PATCH] D78440: [PowerPC] Fix the liveins for ppc-early-ret pass

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang added a comment.

In D78440#1990955 <https://reviews.llvm.org/D78440#1990955>, @efriedma wrote:

> A physical register is "livein" when on entry to that block, the register contains some meaningful value, and that value is used in that block or one of its successors.  Moving an instruction at the end of a block can't affect the liveness at the beginning of that block.  If the register didn't contain a meaningful value before, it still won't contain a meaningful value afterwards.
>
> Please take another look at the input and output to ppc-early-ret, and try to figure out what the correct liveness actually looks like.  Blindly calling addLiveIn might satisfy the verifier, but it won't make the result correct.


Yes, you are right. The real error is in ppc-expand-isel pass. I have create the patch https://reviews.llvm.org/D78657 for this. So I will close this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78440/new/

https://reviews.llvm.org/D78440