[PATCH] D78592: [mlir][SCCP] Add support for propagating across symbol based calls

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/SCCP.cpp:770
+    return;
+  assert(callable->getNumResults() == 0 && "expected symbol callable");
+
----------------
bondhugula wrote:
> Callable things can never have results, right? Can't you assert for the trait instead? Also, this should be moved to before the check right above. 
non-symbol defining callables return the callable as a result value. This check is intended to intended to guard against the missing support for those callables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78592/new/

https://reviews.llvm.org/D78592