[PATCH] D78592: [mlir][SCCP] Add support for propagating across symbol based calls

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/lib/Transforms/SCCP.cpp:599
+  for (auto it : llvm::zip(callResults, callableResults))
+    meet(op, latticeValues[std::get<0>(it)], std::get<1>(it));
+}
----------------
/*owner=*/  /*to=*/  /*from=*/


================
Comment at: mlir/lib/Transforms/SCCP.cpp:772
+
+  // If this terminator is not "region-like", conservatively mark all of the
+  // return values as overdefined.
----------------
region-like -> return-like


================
Comment at: mlir/lib/Transforms/SCCP.cpp:773
+  // If this terminator is not "region-like", conservatively mark all of the
+  // return values as overdefined.
+  auto callableResultLattices = latticeIt->second.getResultLatticeValues();
----------------
return values -> call site results ?


================
Comment at: mlir/lib/Transforms/SCCP.cpp:793
+    for (auto it : llvm::zip(call->getResults(), callableResultLattices))
+      meet(call, latticeValues[std::get<0>(it)], std::get<1>(it));
+}
----------------
Likewise. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78592/new/

https://reviews.llvm.org/D78592