[PATCH] D78615: [ValueTracking] Let propagatesPoison support binops/unaryops/cast/etc.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PoisonChecking.cpp:348
-     arguments, but LangRef doesn't state and propagatesPoison doesn't
-     include these two.
    - all binary ops w/vector operands - The likely interpretation would be that
----------------
I think this makes sense but we need to get input from others on this.


================
Comment at: llvm/test/Analysis/ScalarEvolution/nsw.ll:242
   ret void
 }
 
----------------
Please verify as the function name suggests there is some problem here. I noted in the previous patch that I think this is correct but we should check and potentially change the function name or record our findings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78615/new/

https://reviews.llvm.org/D78615