[PATCH] D78624: [CaptureTracking] Replace hardcoded constant to option. NFC.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 22 09:12:53 PDT 2020
jdoerfert added a comment.
One nit, otherwise this seems fine to me
================
Comment at: llvm/include/llvm/Analysis/CaptureTracking.h:24
- /// The default value for MaxUsesToExplore argument. It's relatively small to
- /// keep the cost of analysis reasonable for clients like BasicAliasAnalysis,
- /// where the results can't be cached.
- /// TODO: we should probably introduce a caching CaptureTracking analysis and
- /// use it where possible. The caching version can use much higher limit or
- /// don't have this cap at all.
- unsigned constexpr DefaultMaxUsesToExplore = 20;
+ unsigned getDefaultMaxUsesToExploreForCaptureTracking();
----------------
Documentation please.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78624/new/
https://reviews.llvm.org/D78624
More information about the llvm-commits
mailing list