[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

Wed Apr 22 08:06:20 PDT 2020

ldionne added a comment.

In D77740#1973239 <https://reviews.llvm.org/D77740#1973239>, @tstellar wrote:

> I didn't think it would be all that much churn.  You could bump trunk to 3.10.2, but then bump cmake on all the builders to 3.13.4, so that you only need to update the builders once.  That seems like the hardest part to me.  But really if you think it's too much extra work, I'm fine just updating once.

The churn isn't in actually doing the upgrade, but in having a discussion on llvm-dev. Concretely, we could probably bump to 3.8 today and nobody would even notice since pretty much all build bots have been updated AFAICT. But having a 2nd discussion on llvm-dev is what I'd like to avoid.

In D77740#1993254 <https://reviews.llvm.org/D77740#1993254>, @smeenai wrote:

> LGTM with the comments about the message addressed.

Sorry for the delay. I've addressed the comments about the message.

I caught up on the llvm-dev thread and it seems like nobody's opposed to my conservative proposal, so I'll move forward with this patch now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77740/new/

https://reviews.llvm.org/D77740