[PATCH] D78623: [flang] Semantic checks for SELECT RANK

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 06:28:19 PDT 2020


DavidTruby accepted this revision.
DavidTruby added a comment.
This revision is now accepted and ready to land.

LGTM but I'm not an expert on this code so wait for approval from someone else



================
Comment at: flang/lib/Semantics/resolve-names.cpp:5111
+    MakePlaceholder(*name, MiscDetails::Kind::SelectRankAssociateName);
+    association.name = &*name;
+  }
----------------
Why does this need de-referencing and then referencing again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78623/new/

https://reviews.llvm.org/D78623





More information about the llvm-commits mailing list