[PATCH] D78549: Improve disassembly of branch targets in non-relocatable objects

Wed Apr 22 03:44:57 PDT 2020

jhenderson marked an inline comment as done.
jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-same-section-addr.test:27
+## Print no target if no symbol in section/absolute symbol found.
+# RUN: yaml2obj %s --docnum=1 -o %t5 -D SIZE1=1 -D SIZE2=0 -D SECTION=.caller -D INDEX=SHN_LOPROC
+# RUN: llvm-objdump -d %t6 | FileCheck %s --check-prefix=FAIL
----------------
Higuoxing wrote:
> ```
> # RUN: yaml2obj ... -o %5 ...
> #                      ^ Should be '%6', right?
> ```
Oops, good spot. That actually is a test bug. The %t6 was left lying around on my machine due to the previous runs using llvm-objcopy. When I fixed %t5 to %t6 here, the test started failing as apparently llvm-objdump treats all symbols without a section (including those with a section index of SHN_LOPROC) as absolute symbols.

I think therefore the only way to do this test is to revert back to my original version using llvm-objcopy (or create an entirely new input).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78549/new/

https://reviews.llvm.org/D78549