[PATCH] D78592: [mlir][SCCP] Add support for propagating across symbol based calls

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

Looks great!

> It assumes that the arguments of callable can be tracked so long as we know that all of the uses are calls.

When can the arguments not be tracked? And shouldn't the CallableOpInterface guarantee that?



================
Comment at: mlir/lib/Transforms/SCCP.cpp:445
+  };
+  SymbolTable::walkSymbolTables(op, !op->getBlock(), walkFn);
+}
----------------
Nit: `/*...=*/!op->getBlock()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78592/new/

https://reviews.llvm.org/D78592