[PATCH] D78503: RFC: [ValueTracking] Let analyses assume a value cannot be partially poison

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune marked 2 inline comments as done.
aqjune added a comment.

I'll make a separate patch for the functional changes.
BTW, regarding the lldb failure that happened on the previous version of this patch, I ran ninja check-all on my ARM machine (with lldb included in the enable_project list) and couldn't reproduce the error. :/ As the patch is being separated, it will be a good chance to see which part is the root cause.



================
Comment at: llvm/lib/Transforms/Instrumentation/PoisonChecking.cpp:347
    - and/or - It would seem reasonable for poison to propagate from both
-     arguments, but LangRef doesn't state and propagatesFullPoison doesn't
-     include these two.
+     arguments, but LangRef doesn't state.
    - all binary ops w/vector operands - The likely interpretation would be that
----------------
jdoerfert wrote:
> Is this true? I mean, don't you check for binary operands above?
It was my misunderstanding about the code, updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78503/new/

https://reviews.llvm.org/D78503