[PATCH] D78602: [llvm-objcopy][MachO] Copy LC_LOAD_WEAK_DYLIB load commands

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 22 00:30:00 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I'm good with this, although I might suggest a different naming scheme with this and related tests, namely to start with "lc"/"load-command" or similar (perhaps lc-weak-dylib.test for this test). That way, all load command tests will appear adjacent to each other in the directory list, because they'll all have the same prefix, making it easier to find tests. Please also use '-' instead of '_' in test names, for consistency with existing tests, and for easier typing!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78602/new/

https://reviews.llvm.org/D78602





More information about the llvm-commits mailing list