[PATCH] D78559: [MLIR] Verify there are no side-effecting ops in GenericAtomicRMWOp body.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:520
+  if (hasSideEffects)
+    return op.emitError("body of 'generic_atomic_rmw' should contain "
+                        "only operations with no side effects");
----------------
herhut wrote:
> It would be extra nice if we could get a note where the side-effecting operation is. But that is icing on the cake.
Having the emitOpError on the operation inside the walk would probably get this achieved nicely I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78559/new/

https://reviews.llvm.org/D78559