[PATCH] D78403: Infer alignment of loads with unspecified alignment in IR/bitcode parsing.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 21:05:07 PDT 2020


mehdi_amini added a comment.

In D78403#1994184 <https://reviews.llvm.org/D78403#1994184>, @arichardson wrote:

> Just one general comment: I wonder if would make more sense to pass the `Module*` to the callback and let the tool perform any changes there?


This was the original revision, I'm against doing this: I think the contract should be left as narrow as possible to express the intent of the API here. This is to express that this is not a hook to "hack whatever you want there" kind of callback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78403/new/

https://reviews.llvm.org/D78403





More information about the llvm-commits mailing list