[PATCH] D78352: [MLIR] Add GenericAtomicRMWOp.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:536
+      return OpBuilder(&block, block.end());
+    }
+    // The value stored in memref[ivs].
----------------
pifon2a wrote:
> herhut wrote:
> > mehdi_amini wrote:
> > > This is the kind of method I expect provided by a Traits otherwise we're losing consistency across all operations with regions.
> > Do you have a new trait in mind or should this be supported by the `SingleBlockImplicitTerminator` trait? The body builder makes only sense if there is a single region. 
> > 
> > These are somewhat widespread already. I'd rather have it as a separate cleanup.
> I am happy to do the cleanup as soon as there is some consensus.
Adding it to `SingleBlockImplicitTerminator` looks fine to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78352/new/

https://reviews.llvm.org/D78352