[PATCH] D78602: [llvm-objcopy][MachO] Copy LC_LOAD_WEAK_DYLIB load commands

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/weak_load_lc.test:1
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy %t %t.copy
----------------
The code looks good, but how is the test named? The actual command is named `LC_LOAD_WEAK_DYLIB`, and I did not expect that the name components are shuffled as weak load lc...

If the test makes more sense as an addition to `basic-executable-copy.test`, please do so, because we probably don't want to add a test for each such command. It seems to me that `basic-executable-copy.test` is a bit complicated now but I don't know whether splitting it is feasible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78602/new/

https://reviews.llvm.org/D78602