[PATCH] D78310: [ProfileSummary] Add partial profile annotation on IR.
Wei Mi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 21 15:44:32 PDT 2020
wmi added a comment.
> Would it be also an option to make the IsPartialProfile MD node optional (by making getFromMD a bit more flexible and treating an absence as "0")? There may be a need to add more fields in the future.
Good suggestion. I was worrying that making some MD node optional may make getFromMD prone to wrong interpretation of fields, but I found getVal has already verified the name of the field.
So I change IsPartialProfile to be optional and I don't need the tests change anymore.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78310/new/
https://reviews.llvm.org/D78310
More information about the llvm-commits
mailing list