[PATCH] D78484: Providing buffer assignment for MLIR

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 14:39:13 PDT 2020


silvas added inline comments.


================
Comment at: mlir/test/lib/Transforms/TestBufferAssignment.cpp:57
+          return rewriter.notifyMatchFailure(
+              op, "dynamic shapes not currently supported");
+        auto memrefType =
----------------
How would this pass be extended to support dynamic shapes? It would be good to have that written down in a comment (and hopefully implemented as a fast follow-on to this CL).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78484/new/

https://reviews.llvm.org/D78484





More information about the llvm-commits mailing list