[PATCH] D76908: [lld-macho] Add support for emitting dylibs with a single symbol

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/MachO/Writer.cpp:334
+  default:
+    error("unhandled output file type");
+    return;
----------------
ruiu wrote:
> When we reach here, it's an internal error. So this line should be `llvm_unreachable` rather than `error`.
This one still needs addressing.


================
Comment at: lld/MachO/Writer.cpp:374
+  default:
+    error("unhandled output file type");
+    return;
----------------
ruiu wrote:
> Ditto
Same here.


================
Comment at: lld/test/MachO/symtab.s:18
 # CHECK-NEXT: ]
 
 .global _main
----------------
MaskRay wrote:
> It seems that the previous diff should not add the symbols which will be deleted by this diff...
The export trie diff will restore these symbols, so I think this is okay. (It's because this diff only supports exporting a single symbol.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76908/new/

https://reviews.llvm.org/D76908