[PATCH] D78560: [mlir][vulkan-runner] Add support for integer types.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst requested changes to this revision.
antiagainst added a comment.
This revision now requires changes to proceed.

Thanks Denis!



================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertGPULaunchFuncToVulkanLaunchFunc.cpp:62
+             (memRefType.getRank() >= 1 && memRefType.getRank() <= 3) &&
+             (elementType.isa<FloatType>() || elementType.isa<IntegerType>());
+    }
----------------
elementType.isIntOrFloat ?


================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp:103
     // Create a type
-    // `!llvm<"{ float*, float*, i64, [`rank` x i64], [`rank` x i64]}">`.
+    // `!llvm<"{ `type`*, `type`*, i64, [`rank` x i64], [`rank` x i64]}">`.
     return LLVM::LLVMType::getStructTy(
----------------
Nit: element-type?


================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp:370
 
+  if (!module.lookupSymbol(kBindMemRef1DInt)) {
+    builder.create<LLVM::LLVMFuncOp>(
----------------
So we have quite a few code blocks that are very similar here. Can we deduplicate a bit either by templates or macros?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78560/new/

https://reviews.llvm.org/D78560