[PATCH] D78538: [llvm][NFC][CallSite] Remove CallSite from DeadArgumentElimination

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 3 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:444
 
-        assert(CS.getArgument(ArgNo)
-               == CS->getOperand(U->getOperandNo())
-               && "Argument is not where we expected it");
+        assert(CB->getArgument(ArgNo) == CB->getOperand(U->getOperandNo()) &&
+               "Argument is not where we expected it");
----------------
MaskRay wrote:
> lebedev.ri wrote:
> > mtrofin wrote:
> > > foad wrote:
> > > > Needs to be `CB->getArgOperand`. This is making my DEBUG build fail.
> > > Noted, doing a rebuild locally to validate there's no other failures and sending a fix asap. Sorry about this.
> > (It might be a really good idea to do all local development with `LLVM_ENABLE_ASSERTIONS` enabled..)
> Just saw the discussions here. I fixed it in cca545ce462b61bdd4bd1b8d81d9eb921e13aebc
> 
> For a CMAKE_BUILD_TYPE=Release build, `-DLLVM_ENABLE_ASSERTIONS` defaults to `OFF`. It may be good setting it to `ON`.
+1 - good suggestion, you mean locally, I assume. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78538/new/

https://reviews.llvm.org/D78538