[PATCH] D78530: Add missing call to `Symbolizer::LateInitialize()` in UBSan's standalone init.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 12:26:37 PDT 2020


vsk accepted this revision.
vsk added a comment.

Thanks!

Adding the extra 'GetOrInit' doesn't sound great to me, it seems like an implementation detail that ought to be guaranteed by LateInitialize.

And I don’t think we should try to not call LateInitialize when it’s not needed. If there’s runtime code that depends on symbolication being present, that’s ok, it shouldn’t have to check for the symbolicator being initialized first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78530/new/

https://reviews.llvm.org/D78530





More information about the llvm-commits mailing list