[PATCH] D75670: [FPEnv] Intrinsic llvm.roundeven

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think the experimental_constrained_roundeven part is uncontroversial.

For the rest, there are two competing interests here:

1. We don't want multiple intrinsics that represent the same thing.
2. Transforming calls to roundeven/rint/nearbyint to one of the other functions is surprising, even if it's legal in some sense, and will likely break some practical use because we don't control the C library.

Violating (1) seems annoying, but not much of a practical problem; the few bits of code that actually care can easily check for three names instead of one.  Violating (2) seems like fodder for weird bug reports I don't want to deal with. Given that, I think we should accept this patch as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75670/new/

https://reviews.llvm.org/D75670