[PATCH] D78063: Remove extra instruction left by emitRLDICWhenLoweringJumpTables

Anil Mahmud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 10:47:55 PDT 2020


anil9 added a comment.

In D78063#1979659 <https://reviews.llvm.org/D78063#1979659>, @lkail wrote:

> Could you pre-commit the test case as an NFC patch so that we can see the difference?


I agree with pre-committing test cases if the codegen will change. But in this case we are simply preventing a crash in the compiler and there is not much use to a test case that just shows that the compiler crashes.

The error would be something like this

   %4:g8rc = RLDICL killed %16:g8rc, 0, 32
   %26:g8rc_and_g8rc_nox0 = RLDIC %16:g8rc, 2, 30
  
  *** Bad machine code: Using a killed virtual register ***
  - function:    fn1
  - basic block: %bb.1 if.then (0x1000a68f270)
  - instruction: %26:g8rc_and_g8rc_nox0 = RLDIC %16:g8rc, 2, 30
  - operand 1:   %16:g8rc
  fatal error: error in backend: Found 1 machine code errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78063/new/

https://reviews.llvm.org/D78063





More information about the llvm-commits mailing list